Skip to content

enforce type_map change when mixed_type#1923

Merged
wanghan-iapcm merged 2 commits into
deepmodeling:develfrom
iProzd:mixed_type_improve
Sep 22, 2022
Merged

enforce type_map change when mixed_type#1923
wanghan-iapcm merged 2 commits into
deepmodeling:develfrom
iProzd:mixed_type_improve

Conversation

@iProzd

@iProzd iProzd commented Sep 18, 2022

Copy link
Copy Markdown
Member

enforce type_map change when mixed_type.
add out_of_bound check for 'real_atom_types.npy'.

enforce type_map change when mixed_type.
add out_of_bound check for 'real_atom_types.npy'.
@codecov-commenter

codecov-commenter commented Sep 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1923 (b443e0d) into devel (58bed2b) will increase coverage by 0.13%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##            devel    #1923      +/-   ##
==========================================
+ Coverage   78.00%   78.14%   +0.13%     
==========================================
  Files         118      118              
  Lines        9853     9872      +19     
==========================================
+ Hits         7686     7714      +28     
+ Misses       2167     2158       -9     
Impacted Files Coverage Δ
deepmd/utils/data.py 90.50% <60.00%> (-1.04%) ⬇️
source/op/_gelu.py 68.42% <0.00%> (-0.81%) ⬇️
deepmd/nvnmd/entrypoints/wrap.py 96.24% <0.00%> (ø)
deepmd/utils/data_system.py 74.57% <0.00%> (+2.42%) ⬆️
deepmd/common.py 84.07% <0.00%> (+4.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iProzd

iProzd commented Sep 18, 2022

Copy link
Copy Markdown
Member Author

@njzjz @wanghan-iapcm

Comment thread deepmd/utils/data.py
Comment thread deepmd/utils/data.py Outdated
Comment thread deepmd/utils/data.py Outdated
@iProzd

iProzd commented Sep 21, 2022

Copy link
Copy Markdown
Member Author

@wanghan-iapcm

@wanghan-iapcm wanghan-iapcm merged commit 5aab6d7 into deepmodeling:devel Sep 22, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
enforce type_map change when mixed_type.
add out_of_bound check for 'real_atom_types.npy'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants