Skip to content

perceive LAMMPS version for built-in mode#1950

Merged
wanghan-iapcm merged 1 commit into
deepmodeling:develfrom
njzjz:detect_lammps_version
Sep 27, 2022
Merged

perceive LAMMPS version for built-in mode#1950
wanghan-iapcm merged 1 commit into
deepmodeling:develfrom
njzjz:detect_lammps_version

Conversation

@njzjz

@njzjz njzjz commented Sep 26, 2022

Copy link
Copy Markdown
Member

Set LAMMPS_VERSION_NUMBER during make yes-user-deepmd. Fixes #1947. The corresponding CMake argument is deprecated.

@codecov-commenter

codecov-commenter commented Sep 26, 2022

Copy link
Copy Markdown

Codecov Report

Base: 78.16% // Head: 78.16% // No change to project coverage 👍

Coverage data is based on head (b52e00f) compared to base (1ba6e53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1950   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files         118      118           
  Lines        9876     9876           
=======================================
  Hits         7720     7720           
  Misses       2156     2156           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm wanghan-iapcm merged commit 8d8080e into deepmodeling:devel Sep 27, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
Set `LAMMPS_VERSION_NUMBER` during `make yes-user-deepmd`. Fixes deepmodeling#1947.
The corresponding CMake argument is deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] set LAMMPS_VERSION_NUMBER before lammps make

3 participants