Skip to content

c++: add clang tests and fix clang errors #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghan-iapcm merged 2 commits into from
Oct 13, 2022
Merged

c++: add clang tests and fix clang errors #1992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee62f4f
test clang
njzjz Oct 12, 2022
675a99a
fix clang errors
njzjz Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/build_cc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
include:
- variant: cpu
- variant: cuda
- variant: clang
steps:
- name: work around permission issue
run: git config --global --add safe.directory /__w/deepmd-kit/deepmd-kit
Expand All @@ -22,10 +23,20 @@ jobs:
if: matrix.variant == 'cpu'
- run: apt-get update && apt-get install -y nvidia-cuda-toolkit
if: matrix.variant == 'cuda'
- run: apt-get update && apt-get install -y clang
if: matrix.variant == 'clang'
- run: source/install/build_cc.sh
env:
DP_VARIANT: ${{ matrix.variant }}
DOWNLOAD_TENSORFLOW: "FALSE"
if: matrix.variant != 'clang'
- run: source/install/build_cc.sh
env:
DP_VARIANT: cpu
DOWNLOAD_TENSORFLOW: "FALSE"
CC: clang
CXX: clang++
if: matrix.variant == 'clang'
# test lammps
- run: source/install/build_lammps.sh
if: matrix.variant == 'cpu'
Expand Down
4 changes: 2 additions & 2 deletions source/api_cc/src/AtomMap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ backward (typename std::vector<VALUETYPE >::iterator out,
}
}

template class AtomMap<float>;
template class AtomMap<double>;
template class deepmd::AtomMap<float>;
template class deepmd::AtomMap<double>;