resolve macos clang errors#1993
Merged
Merged
Conversation
Codecov ReportBase: 73.56% // Head: 19.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1993 +/- ##
===========================================
- Coverage 73.56% 19.11% -54.45%
===========================================
Files 198 196 -2
Lines 19916 18169 -1747
Branches 854 0 -854
===========================================
- Hits 14651 3473 -11178
- Misses 4877 14696 +9819
+ Partials 388 0 -388
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
njzjz
changed the title
njzjz
changed the title
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
changed the title
njzjz
requested review from
wanghan-iapcm
and removed request for
wanghan-iapcm
wanghan-iapcm
approved these changes
Oct 14, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
This is also aimed at resolving macos clang errors: 1. link to protobuf if it's used and separated; 2. add link flags to lmp lib. 3. set rpath; remove gnu specific flags; Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also aimed at resolving macos clang errors: