add Optional to type hints when default is None#2139
Merged
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Nov 29, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
script:
```py
from glob import glob
import re
regex = re.compile(r"([^,\(\)= ]+):[ ]*((?!Optional)[^,\(\)= ]+)[ ]*=[ ]*None")
for ii in glob("deepmd/**/*.py", recursive=True):
with open(ii, 'r') as ff:
content = ff.read()
has_optional = "Optional" in content
has_typing = "from typing" in content
content, nsub = regex.subn(r"\1: Optional[\2] = None", content)
if nsub > 0:
if not has_optional:
if has_typing:
content = content.replace("from typing import", "from typing import Optional,")
else:
content = "from typing import Optional\n" + content
with open(ii, 'w') as ff:
ff.write(content)
```
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Mar 2, 2023
This PR does the same thing as deepmodeling#2139. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
pushed a commit
that referenced
this pull request
Mar 3, 2023
This PR does the same thing as #2139. --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script: