Skip to content

merge print_summary and add it to C API#2207

Merged
wanghan-iapcm merged 6 commits into
deepmodeling:develfrom
njzjz:c-print-summary
Dec 31, 2022
Merged

merge print_summary and add it to C API#2207
wanghan-iapcm merged 6 commits into
deepmodeling:develfrom
njzjz:c-print-summary

Conversation

@njzjz

@njzjz njzjz commented Dec 30, 2022

Copy link
Copy Markdown
Member
  • merge the implementation of deepmd::DeepPot::print_summary and deepmd::DeepTensor::print_summary to deepmd::print_summary
  • add the implementation of deepmd::DipoleChargeModifier::print_summary
  • add DP_PrintSummary, deepmd::hpp::DeepPot::print_summary, deepmd::hpp::DeepTensor::print_summary, and deepmd::hpp::DipoleChargeModifier::print_summary
  • add tests for above

* merge the implementation of `deepmd::DeepPot::print_summary` and `deepmd::DeepTensor::print_summary` to `deepmd::print_summary`
* add implementation of `deepmd::DipoleChargeModifier::print_summary`
* add `DP_PrintSummary`, `deepmd::hpp::DeepPot::print_summary`, `deepmd::hpp::DeepTensor::print_summary`, and `deepmd::hpp::DipoleChargeModifier::print_summary`
* add tests for above

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
…ing&)' cannot have cv-qualifier"

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov-commenter

codecov-commenter commented Dec 30, 2022

Copy link
Copy Markdown

Codecov Report

Base: 74.86% // Head: 74.91% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (bdd669b) compared to base (41180ca).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2207      +/-   ##
==========================================
+ Coverage   74.86%   74.91%   +0.05%     
==========================================
  Files         203      203              
  Lines       20096    20101       +5     
  Branches     1436     1436              
==========================================
+ Hits        15044    15059      +15     
+ Misses       4146     4135      -11     
- Partials      906      907       +1     
Impacted Files Coverage Δ
source/api_cc/include/common.h 0.00% <ø> (ø)
source/api_c/include/deepmd.hpp 93.75% <100.00%> (+0.11%) ⬆️
source/api_c/src/c_api.cc 81.22% <100.00%> (+0.23%) ⬆️
source/api_cc/src/DataModifier.cc 80.68% <100.00%> (+0.27%) ⬆️
source/api_cc/src/DeepPot.cc 66.35% <100.00%> (-0.76%) ⬇️
source/api_cc/src/DeepTensor.cc 84.29% <100.00%> (+3.81%) ⬆️
source/api_cc/src/common.cc 77.62% <100.00%> (+0.81%) ⬆️
source/lib/include/ComputeDescriptor.h 76.65% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz changed the title merge print_summary and add to C API merge print_summary and add it to C API Dec 30, 2022
@wanghan-iapcm wanghan-iapcm merged commit ef39eda into deepmodeling:devel Dec 31, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
* merge the implementation of `deepmd::DeepPot::print_summary` and
`deepmd::DeepTensor::print_summary` to `deepmd::print_summary`
* add the implementation of
`deepmd::DipoleChargeModifier::print_summary`
* add `DP_PrintSummary`, `deepmd::hpp::DeepPot::print_summary`,
`deepmd::hpp::DeepTensor::print_summary`, and
`deepmd::hpp::DipoleChargeModifier::print_summary`
* add tests for above

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants