support the custom training times for each frame#2208
Merged
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportBase: 74.86% // Head: 74.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #2208 +/- ##
==========================================
+ Coverage 74.86% 74.92% +0.06%
==========================================
Files 203 203
Lines 20096 20104 +8
Branches 1436 1438 +2
==========================================
+ Hits 15044 15063 +19
+ Misses 4146 4134 -12
- Partials 906 907 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
Collaborator
There was a problem hiding this comment.
I suggest not naming it as "probability", because a probability should be summed to 1.
"numb_copy" may be a better name, i.e. each frame is copied by the "numb_copy" (int) times. This is the behavior of your PR.
njzjz
changed the title
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Jan 2, 2023
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Before, `sys_probs` only specifies the probability of each system. This patch allows `numb_copy.npy` (`int`) to specify each frame is copied by the "numb_copy" (int) times. The default is 1 for all frames, which keeps the same behavior as before. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before,
sys_probsonly specifies the probability of each system. This patch allowsnumb_copy.npy(int) to specify each frame is copied by the "numb_copy" (int) times. The default is 1 for all frames, which keeps the same behavior as before.