Skip to content

Support dp test with txt#2235

Merged
wanghan-iapcm merged 7 commits into
deepmodeling:develfrom
HuangJiameng:dp_test_with_txt
Jan 11, 2023
Merged

Support dp test with txt#2235
wanghan-iapcm merged 7 commits into
deepmodeling:develfrom
HuangJiameng:dp_test_with_txt

Conversation

@HuangJiameng

Copy link
Copy Markdown
Contributor

Support using a text file(E.G. list.txt) to specify the list of test sets

list.txt

data_dir/sys.000
data_dir/sys.001
data_dir/sys.002
...

/data_dir/sys.000 should be a directory with "type.raw".
Then one can use -l list.txt to replace -s data_dir.

Comment thread deepmd/entrypoints/test.py Outdated
Comment thread deepmd/entrypoints/test.py Outdated
Comment thread deepmd/entrypoints/main.py
@codecov-commenter

codecov-commenter commented Jan 10, 2023

Copy link
Copy Markdown

Codecov Report

Base: 75.66% // Head: 75.65% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (120def1) compared to base (6154494).
Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2235      +/-   ##
==========================================
- Coverage   75.66%   75.65%   -0.01%     
==========================================
  Files         204      204              
  Lines       20249    20255       +6     
  Branches     1438     1438              
==========================================
+ Hits        15321    15324       +3     
- Misses       4021     4025       +4     
+ Partials      907      906       -1     
Impacted Files Coverage Δ
deepmd/entrypoints/test.py 10.90% <0.00%> (-0.21%) ⬇️
deepmd/entrypoints/main.py 91.40% <100.00%> (+0.13%) ⬆️
source/lib/include/ComputeDescriptor.h 76.87% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it is encouraged to add a test.

Comment thread deepmd/entrypoints/test.py Outdated
Comment thread deepmd/entrypoints/test.py Outdated
Comment thread deepmd/entrypoints/test.py Outdated
Comment thread deepmd/entrypoints/main.py Outdated
Comment thread deepmd/entrypoints/test.py Outdated
@wanghan-iapcm wanghan-iapcm merged commit 6322609 into deepmodeling:devel Jan 11, 2023
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
Support using a text file(E.G. `list.txt`) to specify the list of test
sets

list.txt
```
data_dir/sys.000
data_dir/sys.001
data_dir/sys.002
...
```
`/data_dir/sys.000` should be a directory with "type.raw".
Then one can use `-l list.txt` to replace `-s data_dir`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants