fix TestReadFileToString.readfiletostring#2355
Merged
Merged
Conversation
Fix deepmodeling#2346. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #2355 +/- ##
==========================================
- Coverage 74.65% 74.63% -0.02%
==========================================
Files 223 223
Lines 22234 22234
Branches 1627 1627
==========================================
- Hits 16598 16595 -3
Misses 4584 4584
- Partials 1052 1055 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Yi-FanLi
reviewed
Feb 28, 2023
Yi-FanLi
approved these changes
Feb 28, 2023
Yi-FanLi
left a comment
Yi-FanLi
left a comment
Collaborator
There was a problem hiding this comment.
That's a reasonable change. The previous test might fail due to the randomness of convert_pbtxt_to_pb. I approve this PR.
wanghan-iapcm
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2346.