Skip to content

apply the C4 rule (flake8-comprehensions)#2610

Merged
wanghan-iapcm merged 3 commits into
deepmodeling:develfrom
njzjz:flake8-comprehensions
Jun 13, 2023
Merged

apply the C4 rule (flake8-comprehensions)#2610
wanghan-iapcm merged 3 commits into
deepmodeling:develfrom
njzjz:flake8-comprehensions

Conversation

@njzjz

@njzjz njzjz commented Jun 12, 2023

Copy link
Copy Markdown
Member

Apply flake8-comprehensions to make codes simpler.

njzjz and others added 2 commits June 12, 2023 17:27
flake8-comprehensions

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz

njzjz commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

pre-commit.ci autofix

@codecov

codecov Bot commented Jun 12, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.01 🎉

Comparison is base (bb0d02b) 76.66% compared to head (6aea713) 76.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2610      +/-   ##
==========================================
+ Coverage   76.66%   76.68%   +0.01%     
==========================================
  Files         233      233              
  Lines       24146    24174      +28     
  Branches     1693     1707      +14     
==========================================
+ Hits        18511    18537      +26     
  Misses       4518     4518              
- Partials     1117     1119       +2     
Impacted Files Coverage Δ
deepmd/descriptor/se_a.py 95.72% <ø> (ø)
deepmd/fit/dipole.py 95.09% <0.00%> (ø)
deepmd/fit/polar.py 66.83% <0.00%> (ø)
deepmd/fit/ener.py 88.67% <100.00%> (ø)
deepmd/infer/deep_dos.py 67.74% <100.00%> (ø)
deepmd/infer/deep_pot.py 82.72% <100.00%> (ø)
deepmd/train/trainer.py 84.45% <100.00%> (ø)
deepmd/utils/multi_init.py 79.51% <100.00%> (ø)
deepmd/utils/path.py 91.45% <100.00%> (ø)
deepmd/utils/tabulate.py 83.96% <100.00%> (ø)
... and 1 more

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz marked this pull request as ready for review June 12, 2023 22:01
@njzjz njzjz changed the title apply the C4 rule apply the C4 rule (flake8-comprehensions) Jun 12, 2023
@wanghan-iapcm wanghan-iapcm merged commit 74d4ca0 into deepmodeling:devel Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants