Skip to content

support mapping to ghost type#2732

Merged
wanghan-iapcm merged 4 commits into
deepmodeling:develfrom
link89:support-ghost-type
Aug 13, 2023
Merged

support mapping to ghost type#2732
wanghan-iapcm merged 4 commits into
deepmodeling:develfrom
link89:support-ghost-type

Conversation

@link89

@link89 link89 commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Currently pair_coeff support customizing mapping rule by the following way

pair_coeff * * H O H

But there are cases that need to mapping specific atom type to ghost type, or type that doesn't existed in deepmd.

This PR addresses the issue by treating NULL as ghost type, so that users can specify atoms type to be ghost type by the following way

pair coeff * * H O NULL

@github-actions github-actions Bot added the LAMMPS label Aug 9, 2023
@njzjz njzjz changed the base branch from master to devel August 9, 2023 12:37

@njzjz njzjz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other pair styles in LAMMPS use NULL as the placeholder, for example, https://docs.lammps.org/pair_eam.html and https://docs.lammps.org/pair_reaxff.html. It's preferred to use the same key.
Documentation should be added like two above pair styles.

@codecov

codecov Bot commented Aug 9, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +2.16% 🎉

Comparison is base (9a2cc91) 78.72% compared to head (dbcfe4f) 80.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2732      +/-   ##
==========================================
+ Coverage   78.72%   80.89%   +2.16%     
==========================================
  Files         241      209      -32     
  Lines       25582    20749    -4833     
  Branches     1517        0    -1517     
==========================================
- Hits        20140    16784    -3356     
+ Misses       5050     3965    -1085     
+ Partials      392        0     -392     

see 73 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@link89

link89 commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

Update the patch will new placeholder NULL and its usage.

@github-actions github-actions Bot added the Docs label Aug 9, 2023
@link89 link89 requested a review from njzjz August 9, 2023 13:32
@wanghan-iapcm wanghan-iapcm merged commit 4806da0 into deepmodeling:devel Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants