Skip to content

argcheck: restrict the type of elements in a list#2945

Merged
wanghan-iapcm merged 2 commits into
deepmodeling:develfrom
njzjz:argcheck-typing-type
Oct 25, 2023
Merged

argcheck: restrict the type of elements in a list#2945
wanghan-iapcm merged 2 commits into
deepmodeling:develfrom
njzjz:argcheck-typing-type

Conversation

@njzjz

@njzjz njzjz commented Oct 24, 2023

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov

codecov Bot commented Oct 24, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9be507) 75.19% compared to head (1e194e8) 26.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #2945       +/-   ##
===========================================
- Coverage   75.19%   26.82%   -48.38%     
===========================================
  Files         245      243        -2     
  Lines       24690    24567      -123     
  Branches     1599     1599               
===========================================
- Hits        18566     6590    -11976     
- Misses       5188    17265    +12077     
+ Partials      936      712      -224     
Files Coverage Δ
deepmd/utils/argcheck.py 0.00% <ø> (-96.08%) ⬇️

... and 167 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz

njzjz commented Oct 24, 2023

Copy link
Copy Markdown
Member Author

I hope these changes can be carefully reviewed... I may make mistakes.

@wanghan-iapcm wanghan-iapcm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm

Copy link
Copy Markdown
Collaborator

I hope these changes can be carefully reviewed... I may make mistakes.

I find the types was set correctly

@wanghan-iapcm wanghan-iapcm merged commit 6d973ef into deepmodeling:devel Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants