lmp: refactor ixnode#2971
Merged
Merged
Conversation
The current implementation used a complex method to ensute ixnode within [0, nxnodes), but why not using mod ("%") to get the same behavior.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #2971 +/- ##
==========================================
+ Coverage 75.23% 75.26% +0.02%
==========================================
Files 245 245
Lines 24678 24669 -9
Branches 1599 1593 -6
==========================================
Hits 18566 18566
+ Misses 5176 5167 -9
Partials 936 936
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
Collaborator
There was a problem hiding this comment.
different from python, in c++, -1%10 == -1
Member
Author
Got it... |
Member
Author
I follow the resolution here: https://stackoverflow.com/a/1907585/9567349 |
wanghan-iapcm
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation used a complex method to ensure
ixnode(int) within[0, nxnodes-1], but why not use mod ("%") to get the same behavior?