fix restarting from compressed training with type embedding#2996
Merged
wanghan-iapcm merged 4 commits intoNov 20, 2023
Merged
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #2996 +/- ##
==========================================
+ Coverage 75.26% 75.62% +0.36%
==========================================
Files 245 245
Lines 24670 24677 +7
Branches 1593 1593
==========================================
+ Hits 18567 18663 +96
+ Misses 5167 5076 -91
- Partials 936 938 +2 ☔ View full report in Codecov by Sentry. |
Collaborator
|
This bug was not detected by unit tests? Maybe we should add correcponding unit tests as well. |
Member
Author
Good point. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
nahso
approved these changes
Nov 19, 2023
wanghan-iapcm
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2989.