Skip to content

fix(2024Q1): fix lammps nlist sort with large sel#3994

Merged
iProzd merged 9 commits into
deepmodeling:2024Q1from
iProzd:fix_lmp_nlist_2024Q1
Aug 1, 2024
Merged

fix(2024Q1): fix lammps nlist sort with large sel#3994
iProzd merged 9 commits into
deepmodeling:2024Q1from
iProzd:fix_lmp_nlist_2024Q1

Conversation

@iProzd

@iProzd iProzd commented Jul 18, 2024

Copy link
Copy Markdown
Member

Copy from #3993 .

Comment thread deepmd/pt/model/model/make_model.py Fixed
@codecov

codecov Bot commented Jul 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (c09a1f7) to head (0e2e0f6).
Report is 10 commits behind head on 2024Q1.

Files with missing lines Patch % Lines
deepmd/dpmodel/atomic_model/linear_atomic_model.py 50.00% 1 Missing ⚠️
...eepmd/dpmodel/atomic_model/pairtab_atomic_model.py 50.00% 1 Missing ⚠️
deepmd/dpmodel/descriptor/hybrid.py 50.00% 1 Missing ⚠️
deepmd/dpmodel/descriptor/se_r.py 50.00% 1 Missing ⚠️
...epmd/pt/model/atomic_model/pairtab_atomic_model.py 50.00% 1 Missing ⚠️
deepmd/pt/model/descriptor/hybrid.py 75.00% 1 Missing ⚠️
deepmd/pt/model/descriptor/repformers.py 50.00% 1 Missing ⚠️
deepmd/pt/model/descriptor/se_r.py 50.00% 1 Missing ⚠️
deepmd/pt/model/model/frozen.py 50.00% 1 Missing ⚠️
deepmd/pt/model/model/spin_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           2024Q1    #3994      +/-   ##
==========================================
- Coverage   81.64%   81.64%   -0.01%     
==========================================
  Files         496      496              
  Lines       45795    45849      +54     
  Branches     2893     2893              
==========================================
+ Hits        37388    37432      +44     
- Misses       7528     7538      +10     
  Partials      879      879              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz

njzjz commented Jul 29, 2024

Copy link
Copy Markdown
Member

Do you plan to sync with #3993?

@iProzd

iProzd commented Jul 29, 2024

Copy link
Copy Markdown
Member Author

Do you plan to sync with #3993?

yes, fixed in c52a0e0

@njzjz

njzjz commented Jul 30, 2024

Copy link
Copy Markdown
Member

If you want to fix the CI error in 2024Q1, apply #4009 and #4032

@iProzd iProzd merged commit 6d6fbb3 into deepmodeling:2024Q1 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants