Skip to content

fix(cmake): Replace deprecated FetchContent_Populate with FetchContent_MakeAvailable #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghan-iapcm merged 3 commits into from
Nov 5, 2024
Merged

fix(cmake): Replace deprecated FetchContent_Populate with FetchContent_MakeAvailable #4309

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d71333
fix(cmake): Replace deprecated FetchContent_Populate with FetchConten…
njzjz Nov 4, 2024
66acae2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 4, 2024
1c6e139
bump cmake_minimum_required
njzjz Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions source/lmp/plugin/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,14 @@ if(DEFINED LAMMPS_SOURCE_ROOT OR DEFINED LAMMPS_VERSION)
message(STATUS "enable LAMMPS plugin mode")
add_library(lammps_interface INTERFACE)
if(DEFINED LAMMPS_VERSION)
cmake_minimum_required(VERSION 3.11)
cmake_minimum_required(VERSION 3.14)
include(FetchContent)
FetchContent_Declare(
lammps_download
GIT_REPOSITORY https://github.com/lammps/lammps
GIT_TAG ${LAMMPS_VERSION})
FetchContent_GetProperties(lammps_download)
if(NOT lammps_download_POPULATED)
FetchContent_Populate(lammps_download)
set(LAMMPS_SOURCE_ROOT ${lammps_download_SOURCE_DIR})
endif()
FetchContent_MakeAvailable(lammps_download)
set(LAMMPS_SOURCE_ROOT ${lammps_download_SOURCE_DIR})
Comment thread
njzjz marked this conversation as resolved.
endif()
set(LAMMPS_HEADER_DIR ${LAMMPS_SOURCE_ROOT}/src)
message(STATUS "LAMMPS_HEADER_DIR is ${LAMMPS_HEADER_DIR}")
Expand Down