fix(jax): skip padding for non-XLA SavedModels#5602
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesConditional XLA padding in DeepPotJAX
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5602 +/- ##
==========================================
- Coverage 82.35% 81.96% -0.40%
==========================================
Files 896 959 +63
Lines 100952 105593 +4641
Branches 4059 4104 +45
==========================================
+ Hits 83138 86547 +3409
- Misses 16349 17559 +1210
- Partials 1465 1487 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Moved to wanghan-iapcm's inline review thread: #5602 (comment) |
Summary
XlaCallModuleduring C++ initializationnall_realshapes for non-XLA SavedModelsThis is mainly to support #5598: padding only has value for XLA static-shape execution and otherwise changes the non-XLA inference shape unnecessarily.
Tests
git diff --checkcmake --build source/build --target deepmd_cc -j2ruff check .ruff format --check .Not run: JAX C++ SavedModel runtime test, because local
source/tests/infer/deeppot_dpa.savedmodelis not available.Summary by CodeRabbit