Remove os.mknod in deepmd/{raw.py,comp.py}#149
Merged
Conversation
method os.mknod is not supported for MacOS and Windows.
Codecov Report
@@ Coverage Diff @@
## devel #149 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 28 28
Lines 3375 3376 +1
=======================================
+ Hits 2854 2855 +1
Misses 521 521
Continue to review full report at Codecov.
|
njzjz
reviewed
May 6, 2021
njzjz
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.mknod method is not supported on MacOS and Windows.
See
https://stackoverflow.com/questions/32115715/os-mknod-fails-on-macos
Suggest use "with open" method