Skip to content

Rewrite abacus interface on devel branch; add unites for qe/pw/scf's crystal unit atomic positions read in.#154

Merged
amcadmus merged 8 commits into
deepmodeling:develfrom
Liu-RX:devel
May 20, 2021
Merged

Rewrite abacus interface on devel branch; add unites for qe/pw/scf's crystal unit atomic positions read in.#154
amcadmus merged 8 commits into
deepmodeling:develfrom
Liu-RX:devel

Conversation

@Liu-RX

@Liu-RX Liu-RX commented May 10, 2021

Copy link
Copy Markdown
Contributor

Rewrote abacus interface based on devel branch;
added unittest for qe/pw/scf's crystal unit atomic positions read in.

@Liu-RX Liu-RX changed the title Devel Rewrite abacus interface on devel branch; add unites for qe/pw/scf's crystal unit atomic positions read in. May 10, 2021
@njzjz

njzjz commented May 10, 2021 via email

Copy link
Copy Markdown
Member

@Liu-RX

Liu-RX commented May 11, 2021

Copy link
Copy Markdown
Contributor Author

it’s better to remove .DS_Store

Got that! I will remove the file next time.

@codecov-commenter

codecov-commenter commented May 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #154 (2aaf9f5) into devel (19e08df) will increase coverage by 0.29%.
The diff coverage is 87.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #154      +/-   ##
==========================================
+ Coverage   79.30%   79.59%   +0.29%     
==========================================
  Files          33       34       +1     
  Lines        4184     4357     +173     
==========================================
+ Hits         3318     3468     +150     
- Misses        866      889      +23     
Impacted Files Coverage Δ
dpdata/qe/scf.py 94.11% <86.66%> (-2.79%) ⬇️
dpdata/abacus/scf.py 86.98% <86.98%> (ø)
dpdata/system.py 80.61% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e08df...2aaf9f5. Read the comment docs.

@amcadmus

Copy link
Copy Markdown
Member

it’s better to remove .DS_Store

Got that! I will remove the file next time.

Please remove the file then I will merge this PR.

@Liu-RX

Liu-RX commented May 20, 2021

Copy link
Copy Markdown
Contributor Author

it’s better to remove .DS_Store

Got that! I will remove the file next time.

Please remove the file then I will merge this PR.

Sorry for the delay. I didn't notice the reply last week. I have already deleted the .DS_Store files and recommitted.

@amcadmus

Copy link
Copy Markdown
Member

Please resolve the conflict.

@Liu-RX

Liu-RX commented May 20, 2021

Copy link
Copy Markdown
Contributor Author

Please resolve the conflict.

Already resolved the conflict.

@amcadmus amcadmus merged commit 5a93f08 into deepmodeling:devel May 20, 2021
@Liu-RX Liu-RX deleted the devel branch October 15, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants