Skip to content

enable unittests of ase and pymatgen#171

Merged
amcadmus merged 2 commits into
deepmodeling:develfrom
njzjz:ut-ase-pymatgen
Jul 15, 2021
Merged

enable unittests of ase and pymatgen#171
amcadmus merged 2 commits into
deepmodeling:develfrom
njzjz:ut-ase-pymatgen

Conversation

@njzjz

@njzjz njzjz commented Jul 9, 2021

Copy link
Copy Markdown
Member

related issue: #170

@njzjz

njzjz commented Jul 9, 2021

Copy link
Copy Markdown
Member Author

... Seems there is a breaking change in pymatgen. https://pymatgen.org/#major-announcement-v2022-0

If your existing code uses from pymatgen import , you will need to make modifications. MPRester should now be imported from pymatgen.ext.matproj. All other convenience objects such as Element, Species, Lattice, Structure, etc. should be imported from pymatgen.core.

@codecov-commenter

codecov-commenter commented Jul 9, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.19%. Comparing base (f0273f7) to head (cbf3ed8).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #171      +/-   ##
==========================================
+ Coverage   80.07%   81.19%   +1.12%     
==========================================
  Files          54       54              
  Lines        4553     4553              
==========================================
+ Hits         3646     3697      +51     
+ Misses        907      856      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz njzjz mentioned this pull request Jul 9, 2021
21 tasks
@njzjz njzjz requested a review from amcadmus July 9, 2021 23:57
@amcadmus amcadmus merged commit d238c6a into deepmodeling:devel Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants