add MultiSystem for ASE traj(or any other format can be read by ASE)#190
Merged
Conversation
fix bug(?) for ASE 'to_labeled_system'
njzjz
requested changes
Aug 30, 2021
njzjz
left a comment
njzjz
left a comment
Member
There was a problem hiding this comment.
Please set the target branch to devel instead of master (you can click the edit button).
add error type of exception
njzjz
approved these changes
Aug 30, 2021
amcadmus
approved these changes
Aug 31, 2021
njzjz
added a commit
to njzjz/dpdata
that referenced
this pull request
May 23, 2022
deepmodeling#190 added `from_labeled_system`, but it just passes a dict and does nothing else. This commit rewrites it.
wanghan-iapcm
pushed a commit
that referenced
this pull request
May 23, 2022
#190 added `from_labeled_system`, but it just passes a dict and does nothing else. This commit rewrites it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add MultiSystem for ASE traj(or any other format can be read by ASE)
fix bug(?) for ASE 'to_labeled_system'