Improve support for ASE's io library#238
Merged
Merged
Conversation
Merge recent development on devel into master
Merge bug fixings to master
merge bug fixings to master
1. Changes keyword argument in `from_multii_systems` for file format from `fmt` to `ase_fmt` to not collide with the keyword argument name used in `MultiSystems.from_file`. 2. Adds documentation to the main README and ASE plugin class
njzjz
approved these changes
Jan 14, 2022
wanghan-iapcm
approved these changes
Jan 15, 2022
Codecov Report
@@ Coverage Diff @@
## devel #238 +/- ##
==========================================
+ Coverage 82.04% 82.83% +0.79%
==========================================
Files 58 58
Lines 5034 5266 +232
==========================================
+ Hits 4130 4362 +232
Misses 904 904
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_muliti_systemsfor file format fromfmttoase_fmtto not collide with the keyword argument name used inMultiSystems.from_file.Fixes #224