add default cells when loading hdf5 data#262
Merged
Merged
Conversation
Now dpdata requires cells even in nopbc data.
Codecov Report
@@ Coverage Diff @@
## devel #262 +/- ##
==========================================
- Coverage 82.09% 82.06% -0.03%
==========================================
Files 60 60
Lines 5150 5153 +3
==========================================
+ Hits 4228 4229 +1
- Misses 922 924 +2
Continue to review full report at Codecov.
|
wanghan-iapcm
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpdata requires cells even in nopbc data.