adapt dpdata interface to ABACUS 2.2.0, fixed issue#268 about qe/pw/scf#270
Conversation
add running_md.log file
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
There was a problem hiding this comment.
This PR includes two modifications. 1, adapt to abacus 2.2 and 2 fix issue #268 . Please raise two separate PRs next time for each modification.
Could you please also explain if your PR is backward compatible? Does it work with older abacus versions?
| #print("dump_idx = %s" %dump_idx) | ||
| coords[dump_idx] = get_single_coord_from_cif(pos_file, atom_names, natoms, cell) | ||
| return coords | ||
| return coords''' |
There was a problem hiding this comment.
Please REMOVE the lines if you do not need them anymore. Do NOT use the doc string to comment out the code.
There was a problem hiding this comment.
This PR includes two modifications. 1, adapt to abacus 2.2 and 2 fix issue #268 . Please raise two separate PRs next time for each modification.
Could you please also explain if your PR is backward compatible? Does it work with older abacus versions?
The PR is no longer backward compatible. I consulted my tutor Mohan and he asked me to do so.
There was a problem hiding this comment.
Please REMOVE the lines if you do not need them anymore. Do NOT use the doc string to comment out the code.
Sorry for that. I will fix it.
Codecov Report
@@ Coverage Diff @@
## devel #270 +/- ##
==========================================
- Coverage 81.65% 81.38% -0.28%
==========================================
Files 61 61
Lines 5185 5115 -70
==========================================
- Hits 4234 4163 -71
- Misses 951 952 +1
Continue to review full report at Codecov.
|
Liu-RX
changed the title
3 participants
No description provided.