add option to ignore convergence check for vasp/contcar#355
Merged
Conversation
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Contributor
Author
|
Similar changes have been made to |
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Contributor
|
Please solve the issues in the UTs. |
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Codecov Report
@@ Coverage Diff @@
## devel #355 +/- ##
==========================================
- Coverage 82.18% 82.16% -0.03%
==========================================
Files 66 66
Lines 5798 5819 +21
==========================================
+ Hits 4765 4781 +16
- Misses 1033 1038 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
njzjz
reviewed
Sep 5, 2022
Comment on lines
+8
to
+9
| if "converge" not in kwargs.keys(): | ||
| kwargs["converge"] = True |
Member
There was a problem hiding this comment.
This should use dict.setdefault or be directly written into the method definition line.
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
njzjz
approved these changes
Sep 5, 2022
| @Format.register("fhi_aims/output") | ||
| class FhiMDFormat(Format): | ||
| def from_labeled_system(self, file_name, md=True, begin = 0, step = 1, **kwargs): | ||
| def from_labeled_system(self, file_name, md=True, begin = 0, step = 1, converge=True, **kwargs): |
Contributor
There was a problem hiding this comment.
I would suggest using req_converge or convergence_check in the interface, because it is more self-explanary.
The same suggest for the pwmat and vasp interfaces.
Contributor
Author
There was a problem hiding this comment.
All are denoted by convergence_check.
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
Signed-off-by: Pan Xiang <panxiang126@gmail.com>
panxiang126
requested review from
njzjz and
wanghan-iapcm
and removed request for
njzjz and
wanghan-iapcm
wanghan-iapcm
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is the realization for discussion #350.