Skip to content

avoid modifying appended system#483

Merged
wanghan-iapcm merged 2 commits into
deepmodeling:develfrom
njzjz:copy-append
Jun 22, 2023
Merged

avoid modifying appended system#483
wanghan-iapcm merged 2 commits into
deepmodeling:develfrom
njzjz:copy-append

Conversation

@njzjz

@njzjz njzjz commented Jun 13, 2023

Copy link
Copy Markdown
Member

When sys1.append(sys2), we do not hope that sys2 to be modified in any way.

njzjz added 2 commits June 13, 2023 16:29
When sys1.append(sys2), we do not hope that sys2 to be modified in any way.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov

codecov Bot commented Jun 13, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01 ⚠️

Comparison is base (ec232f8) 82.70% compared to head (663d9e8) 82.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #483      +/-   ##
==========================================
- Coverage   82.70%   82.69%   -0.01%     
==========================================
  Files          70       70              
  Lines        6395     6398       +3     
==========================================
+ Hits         5289     5291       +2     
- Misses       1106     1107       +1     
Impacted Files Coverage Δ
dpdata/system.py 85.61% <75.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants