Skip to content

add support for n2p2 data format#627

Merged
wanghan-iapcm merged 15 commits into
deepmodeling:masterfrom
Yi-FanLi:n2p2
Apr 3, 2024
Merged

add support for n2p2 data format#627
wanghan-iapcm merged 15 commits into
deepmodeling:masterfrom
Yi-FanLi:n2p2

Conversation

@Yi-FanLi

@Yi-FanLi Yi-FanLi commented Apr 2, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Apr 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (18a0ed5) to head (cfb6d7d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   82.81%   83.08%   +0.27%     
==========================================
  Files          73       74       +1     
  Lines        6580     6686     +106     
==========================================
+ Hits         5449     5555     +106     
  Misses       1131     1131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test?

Comment thread dpdata/plugins/np2p.py
@Yi-FanLi

Yi-FanLi commented Apr 2, 2024

Copy link
Copy Markdown
Collaborator Author

could you add a test?

added by commit 506b187

@Yi-FanLi Yi-FanLi requested a review from njzjz April 2, 2024 22:36

@njzjz njzjz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wanghan-iapcm wanghan-iapcm merged commit e2f235f into deepmodeling:master Apr 3, 2024
@wanghan-iapcm

Copy link
Copy Markdown
Contributor

@njzjz i merged it to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants