Skip to content

No way to pass parameter "md" in gaussian/log#91

Merged
amcadmus merged 1 commit into
deepmodeling:masterfrom
weijunji:master
Apr 9, 2020
Merged

No way to pass parameter "md" in gaussian/log#91
amcadmus merged 1 commit into
deepmodeling:masterfrom
weijunji:master

Conversation

@weijunji

@weijunji weijunji commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

the gaussian/log function has a parameter md, but there is no way to pass it.

def to_system_data(file_name, md=False):

fix this bug, add **kwargs in __init__ of class System

@codecov-io

codecov-io commented Apr 7, 2020

Copy link
Copy Markdown

Codecov Report

Merging #91 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files          24       24           
  Lines        2836     2836           
=======================================
  Hits         2454     2454           
  Misses        382      382           
Impacted Files Coverage Δ
dpdata/system.py 84.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dac5ff...d043b1b. Read the comment docs.

@amcadmus amcadmus requested a review from njzjz April 7, 2020 06:34
@njzjz

njzjz commented Apr 7, 2020 via email

Copy link
Copy Markdown
Member

@amcadmus amcadmus merged commit dfdd9bd into deepmodeling:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants