chore: remove preview code from the 1.x release line#6447
Merged
Conversation
masci
requested review from
dfokina and
julian-risch
and removed request for
a team
github-actions
Bot
added
topic:tests
topic:dependencies
topic:build/distribution
topic:CI
2.x
type:documentation
masci
added
the
ignore-for-release-notes
julian-risch
approved these changes
Nov 29, 2023
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
LGTM! 🚢 I went through the list of files and I also searched for preview in all the other files but there is no trace of it anymore. 👍
anakin87
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.