Skip to content

fix: load_from_deepset_cloud without name in yaml#6478

Merged
silvanocerza merged 3 commits into
v1.xfrom
fix/load_from_deepset_cloud_no_name
Dec 4, 2023
Merged

fix: load_from_deepset_cloud without name in yaml#6478
silvanocerza merged 3 commits into
v1.xfrom
fix/load_from_deepset_cloud_no_name

Conversation

@tstadel
Copy link
Copy Markdown
Member

@tstadel tstadel commented Dec 4, 2023

Related Issues

Proposed Changes:

  • fix Pipeline.load_from_deepset_cloud if yaml does not contain "name". This is the case for all newly created dC pipelines.

How did you test it?

  • ran existing sdk tests (They were actually catching the bug).

Notes for the reviewer

  • unfortunately the sdk tests are not run during CI. I ran them all locally and fixed where needed.

Checklist

@tstadel tstadel requested a review from a team as a code owner December 4, 2023 11:11
@tstadel tstadel requested review from silvanocerza and removed request for a team December 4, 2023 11:11
@tstadel tstadel requested a review from a team as a code owner December 4, 2023 11:28
@tstadel tstadel requested review from dfokina and removed request for a team December 4, 2023 11:28
@silvanocerza silvanocerza merged commit 41e9c29 into v1.x Dec 4, 2023
@silvanocerza silvanocerza deleted the fix/load_from_deepset_cloud_no_name branch December 4, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants