chore: remove OpenAIAnswerGenerator#6531
Merged
Merged
Conversation
github-actions
Bot
added
topic:pipeline
topic:tests
type:documentation
ZanSara
requested review from
anakin87 and
dfokina
and removed request for
a team
anakin87
reviewed
Dec 13, 2023
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
In general, it looks good.
Let's improve the release note...
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| deprecations: | |||
Member
There was a problem hiding this comment.
According to reno convention, this should not appear on deprecations.
haystack/releasenotes/config.yaml
Line 32 in a55024b
So, we should probably compile the upgrade section, explaining to users to replace this component with the PromptNode; maybe we can link some docs or tutorials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
OpenAIAnswerGeneratorfrom the repo #6458Proposed Changes:
OpenAIAnswerGeneratorand all the test related to it.How did you test it?
CI
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.