Skip to content

fix: HFInvocationLayer - convert use_auth_token to token#6533

Merged
anakin87 merged 2 commits into
v1.xfrom
fix-use-auth-token-prompt-node
Dec 12, 2023
Merged

fix: HFInvocationLayer - convert use_auth_token to token#6533
anakin87 merged 2 commits into
v1.xfrom
fix-use-auth-token-prompt-node

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Dec 12, 2023

Related Issues

Investigating the issue, I discovered that all the problems disappear if we create a Hugging Face Pipeline using token instead of the old use_auth_token.

Proposed Changes:

  • Internally convert use_auth_token to token
  • I chose to not change the parameter name in the public API, to avoid a breaking change. In 2.0, we already have the right parameter name.

How did you test it?

CI. Addition to existing test. Manual verification (described here: #6501 (comment)).

Checklist

@anakin87 anakin87 requested a review from a team as a code owner December 12, 2023 14:29
@anakin87 anakin87 requested review from silvanocerza and removed request for a team December 12, 2023 14:29
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 12, 2023
Copy link
Copy Markdown
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZanSara ZanSara added this to the 1.23.0 milestone Dec 12, 2023
@anakin87 anakin87 merged commit 5304193 into v1.x Dec 12, 2023
@anakin87 anakin87 deleted the fix-use-auth-token-prompt-node branch December 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants