fix(zero): enable vmap on LinearFunctionForZeroStage3#8023
Open
roycho96 wants to merge 1 commit into
Open
Conversation
The forward is a pure tensor op (addmm / matmul + bias) with no closure state, so PyTorch's auto-generated vmap rule produces correct batched semantics. Without this, vmap (and vmap(grad)) over the Function raises 'does not have vmap support', the case the setup_context fix in deepspeedai#7916 left unaddressed. Signed-off-by: Sung Hyun Cho <hope5487@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7916.
Adds
generate_vmap_rule = TruetoLinearFunctionForZeroStage3sotorch.func.vmapworks on the Function directly. The previous PR coveredgrad/jacrevviasetup_contextbut notvmap.Test:
pytest tests/unit/v1/zero/test_zero_functorch_linear.py::TestLinearFunctionVmap