Fix repeated gradient scaling across pipeline stages - #8154
Merged
tohtana merged 1 commit intoJul 20, 2026
Conversation
Signed-off-by: Yuchen Fan <functionhx@gmail.com>
Functionhx
marked this pull request as ready for review
July 18, 2026 04:43
tohtana
approved these changes
Jul 20, 2026
tohtana
left a comment
Collaborator
There was a problem hiding this comment.
Hi @Functionhx,
Thank you for submitting this PR! This looks good to me.
I know this type of bug is very hard to find and fix. I appreciate your continuous contribution.
tohtana
enabled auto-merge
July 20, 2026 22:20
PKUWZP
approved these changes
Jul 20, 2026
PKUWZP
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the PR!
Merged
via the queue into
deepspeedai:master
with commit Jul 20, 2026
d99a642
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix repeated gradient accumulation scaling when pipeline parallelism is combined with gradient accumulation.
Every pipeline stage registers an output backward hook that scales gradients by
gradient_accumulation_steps. The last stage therefore scales the gradient correctly before sending it upstream, but each preceding stage scales the already-scaled gradient again.Fixes #8152
Changes
gradient_accumulation_steps=1.Testing
DS_ACCELERATOR=cpu LOCAL_SIZE=2 OMP_NUM_THREADS=1 pytest -q tests/unit/runtime/pipe/test_pipe.py::TestPipeGradientAccumulationScaling::test_gradients_are_scaled_oncepre-commit run --files deepspeed/runtime/pipe/engine.py tests/unit/runtime/pipe/test_pipe.pygradient_accumulation_steps=1,2,8