fix(storage): validate named S3 backend names & remove lock-across-await#4
Merged
Merged
Conversation
…wait - config: reject URL-incompatible named-backend names at config load; the name is embedded in the s3+<name>:// scheme which the metrics/DataFusion path parses with url::Url. Restricted to lowercase ASCII alnum and `-`. - storage: cache each named backend behind its own OnceCell; the mutex is held only synchronously to fetch/insert the cell, never across the client build, so independent backends initialize concurrently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the named S3 backend feature.
StorageConfigs::validate). The name is embedded in thes3+<name>://URI scheme, which the metrics/DataFusion path parses withurl::Url; restricted to lowercase ASCII alnum and-so it fails fast at startup instead of at query time.OnceCell; the (nowstd) mutex is held only synchronously to fetch/insert the cell, never across the client build, so independent backends initialize concurrently.Tests: name validation unit tests (config). clippy clean, fmt clean, quickwit-config 104/104 and quickwit-storage 65/65 lib tests pass. Resolver change is compile-checked only (no runtime test).