[WIP] upgrade to browserify 9.0.3#20
Open
marcello3d wants to merge 1 commit into
Open
Conversation
Collaborator
marcello3d
commented
Mar 17, 2015
marcello3d
commented
- update to new API
- passes all tests except ‘routes’
- update to new API - passes all tests except ‘routes’
Owner
|
any thoughts on why failing? |
Collaborator
Author
|
No, I want you to look at it. Hence WIP and my comment about all tests except routes passing. :-) |
Collaborator
Author
|
The test failure is a browserify bug. @defunctzombie made a reproducible test case: browserify/browserify#1171 |
Contributor
|
Have you managed to update browserify to latest version? |
Contributor
|
Tried latest, still no go |
Owner
|
What is the issue? On Saturday, September 5, 2015, Theo Gravity notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.