feat(auth): add auth:whoami endpoint#36
Conversation
| // | ||
| // If the SDK detects an API version mismatch, it will return ErrAPIMismatch. | ||
| const APIVersion = "2.1" | ||
| const APIVersion = "2.2" |
There was a problem hiding this comment.
does this patch need to be delayed until the 2.2 release? also, we can toggle this at build time
There was a problem hiding this comment.
Nah this is the API version bump rather than the platform version bump. These are versioned separately, but because we've had new features in the API these past two releases they are identical. We only bump the API once between platform releases, if necessary. :)
Note that deis/controller#737 also bumps the API version, and deis/workflow#367 adds a v2.2 API reference doc.
There was a problem hiding this comment.
However this is stuck until all the PRs go green though so we don't have an API version mismatch between the client and the server.
I can PR this separately if you'd like!
There was a problem hiding this comment.
ah, right. I forget about the distinction. thanks for reminding!
|
LGTM2 assuming #36 (comment) is addressed |
bacongobbler
force-pushed
the
auth-whoami
branch
from
6d5b817 to
6a5aa20
Compare
feat(auth): add auth:whoami endpoint
4 participants
refs deis/workflow-cli#118