Skip to content

feat: add getLeaderBoardbyTier and leaderboard update events#13

Merged
Ram-20062003 merged 18 commits intomainfrom
leaderboard
Feb 27, 2023
Merged

feat: add getLeaderBoardbyTier and leaderboard update events#13
Ram-20062003 merged 18 commits intomainfrom
leaderboard

Conversation

@Valliammai-SM
Copy link
Copy Markdown

No description provided.

@Valliammai-SM Valliammai-SM changed the base branch from apis to main February 6, 2023 06:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #13 (1cfb260) into main (a1ef0ec) will increase coverage by 1.55%.
The diff coverage is 73.01%.

@@             Coverage Diff              @@
##               main      #13      +/-   ##
============================================
+ Coverage     50.05%   51.60%   +1.55%     
- Complexity      310      320      +10     
============================================
  Files            87       87              
  Lines          1756     1802      +46     
  Branches        166      171       +5     
============================================
+ Hits            879      930      +51     
+ Misses          821      815       -6     
- Partials         56       57       +1     
Impacted Files Coverage Δ
...lin/delta/codecharacter/server/user/UserService.kt 4.80% <0.00%> (-0.08%) ⬇️
...n/delta/codecharacter/server/match/MatchService.kt 45.96% <21.42%> (+0.47%) ⬆️
...acter/server/user/public_user/PublicUserService.kt 35.46% <94.28%> (+31.79%) ⬆️
...decharacter/server/schedulers/SchedulingService.kt 100.00% <100.00%> (ø)
...racter/server/user/public_user/PublicUserEntity.kt 100.00% <100.00%> (ø)
...odecharacter/server/leaderboard/LeaderBoardEnum.kt 0.00% <0.00%> (-100.00%) ⬇️
...lin/delta/codecharacter/server/game/GameService.kt 93.47% <0.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread server/src/main/resources/application.example.yml
Copy link
Copy Markdown
Collaborator

@Ram-20062003 Ram-20062003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Have proper function naming for all functions
  • Improve the code quality. Try reducing redundant queries
  • Move all functions in LeaderBoardScheduling to Scheduling Service

Comment thread server/src/main/kotlin/delta/codecharacter/server/user/UserService.kt Outdated
@Valliammai-SM Valliammai-SM force-pushed the leaderboard branch 2 times, most recently from c747a88 to f30fd8d Compare February 19, 2023 15:11
@vigneshd332
Copy link
Copy Markdown
Member

vigneshd332 commented Feb 27, 2023

We can remove leaderboard enum if not used right?

@Ram-20062003 Ram-20062003 changed the title feat: leaderboard tiers feat: add getLeaderBoardbyTier and leaderboard update events Feb 27, 2023
@Ram-20062003 Ram-20062003 merged commit 8b5a839 into main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants