feat: add getLeaderBoardbyTier and leaderboard update events#13
Merged
Ram-20062003 merged 18 commits intomainfrom Feb 27, 2023
Merged
feat: add getLeaderBoardbyTier and leaderboard update events#13Ram-20062003 merged 18 commits intomainfrom
Ram-20062003 merged 18 commits intomainfrom
Conversation
255ef9e to
4a3b836
Compare
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
============================================
+ Coverage 50.05% 51.60% +1.55%
- Complexity 310 320 +10
============================================
Files 87 87
Lines 1756 1802 +46
Branches 166 171 +5
============================================
+ Hits 879 930 +51
+ Misses 821 815 -6
- Partials 56 57 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ram-20062003
requested changes
Feb 9, 2023
Ram-20062003
requested changes
Feb 13, 2023
Collaborator
Ram-20062003
left a comment
There was a problem hiding this comment.
- Have proper function naming for all functions
- Improve the
code quality. Try reducing redundant queries - Move all functions in
LeaderBoardSchedulingtoScheduling Service
c747a88 to
f30fd8d
Compare
53e1475 to
bc95fde
Compare
Member
|
We can remove leaderboard enum if not used right? |
vigneshd332
approved these changes
Feb 27, 2023
Ram-20062003
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.