feat(dc): Add seeders for daily challenge and add get route for daily challenges#6
Merged
Ram-20062003 merged 16 commits intomainfrom Jan 12, 2023
Merged
feat(dc): Add seeders for daily challenge and add get route for daily challenges#6Ram-20062003 merged 16 commits intomainfrom
Ram-20062003 merged 16 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
============================================
- Coverage 51.07% 49.77% -1.30%
- Complexity 251 255 +4
============================================
Files 75 79 +4
Lines 1300 1358 +58
Branches 101 104 +3
============================================
+ Hits 664 676 +12
- Misses 613 656 +43
- Partials 23 26 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ram-20062003
requested changes
Jan 3, 2023
Collaborator
Ram-20062003
left a comment
There was a problem hiding this comment.
Changes Requested
- Remove the script for db-seeders and add
seedersin spring-boot. - Revert all the un-necessary changes.
- Configure your
.gitignoreproperly. - Get
event_start_datefromapplication.ymland find the day for allocating the daily challenge.
Ram-20062003
requested changes
Jan 5, 2023
Collaborator
There was a problem hiding this comment.
Changes Requested
- Remove
start_datefromdocker env. Get thestart_datefromapplication.yml - Replace the
hardcodeddcConstants filepath. - Remove
printstatements. Instead uselogger.
// example
private val logger : Logger = LoggerFactory.getLogger(DailyChallengeSeeder::class.java)
logger.info("Your Log Statemnent")Seed the databaseonly when needed- Store the
start_datein formatYYYY-mm-ddHH:MM:ssZ, so we can get the exact 24 hr count for posting daily challenge - Pull the recent commits from
mainand update PR accordingly. - /dc/get route will be returning the status of the chall which says whether the user has completed or not. So make it as a protected route . The route already accepts
jwtasBearer token - Do remove
seed.jsfrom.gitignoreandharcodedvalues
Ram-20062003
requested changes
Jan 8, 2023
…emoved completionStatus
Ram-20062003
requested changes
Jan 9, 2023
Ram-20062003
requested changes
Jan 12, 2023
Collaborator
|
Run format and fix lint-issues |
Ram-20062003
approved these changes
Jan 12, 2023
Ashwin125
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Todo