Skip to content

feat: add tutorials and recaptcha-validations#7

Merged
vigneshd332 merged 9 commits intomainfrom
addTiers
Jan 22, 2023
Merged

feat: add tutorials and recaptcha-validations#7
vigneshd332 merged 9 commits intomainfrom
addTiers

Conversation

@Valliammai-SM
Copy link
Copy Markdown

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 1, 2023

Codecov Report

Merging #7 (f9e09ab) into main (82edb0e) will decrease coverage by 1.39%.
The diff coverage is 2.27%.

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     49.66%   48.28%   -1.39%     
- Complexity      255      257       +2     
============================================
  Files            79       79              
  Lines          1359     1400      +41     
  Branches        104      110       +6     
============================================
+ Hits            675      676       +1     
- Misses          658      698      +40     
  Partials         26       26              
Impacted Files Coverage Δ
...lin/delta/codecharacter/server/user/UserService.kt 5.30% <0.00%> (-1.51%) ⬇️
...acter/server/user/public_user/PublicUserService.kt 4.54% <0.00%> (-0.94%) ⬇️
...racter/server/user/public_user/PublicUserEntity.kt 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Collaborator

@Ram-20062003 Ram-20062003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested

  • Pull rebase your PR
  • Change user.reCaptcha-key->environment.reCaptcha-key (yaml format)
  • Make your corresponding changes in application.docker.example.yml also
  • UpdateTutorial is not proper. Fix it
  • Fix recaptcha verification
  • Write test to handle the tier-based-matching customexception

(Please make the following changes @Valliammai-SM . If you have any doubts let us know)

Comment thread server/src/main/kotlin/delta/codecharacter/server/user/UserService.kt Outdated
Comment thread server/src/main/kotlin/delta/codecharacter/server/user/UserService.kt Outdated
Comment thread server/src/main/kotlin/delta/codecharacter/server/user/UserService.kt Outdated
Comment thread server/src/main/kotlin/delta/codecharacter/server/user/UserService.kt Outdated
Comment thread server/src/main/resources/application.example.yml Outdated
@Ram-20062003 Ram-20062003 changed the title Add tutorial completion check feat: add tutorials and recaptcha-validations Jan 21, 2023
@vigneshd332 vigneshd332 self-requested a review January 22, 2023 12:31
@vigneshd332 vigneshd332 merged commit ef89564 into main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants