Skip to content

postgres ssl#19

Merged
dennis-tra merged 7 commits into
dennis-tra:mainfrom
coryschwartz:feat/postgres-ssl
Jan 21, 2022
Merged

postgres ssl#19
dennis-tra merged 7 commits into
dennis-tra:mainfrom
coryschwartz:feat/postgres-ssl

Conversation

@coryschwartz
Copy link
Copy Markdown
Contributor

I was working on a helm chart to deploy this. If you want to have a gander, that can be seen here filecoin-project/helm-charts#121

Our postgres database is configured limit connections only from secure sslmodes, so I added another flag to parameterize it and changed the default.

Comment thread deploy/docker-compose.yml Outdated
@dennis-tra
Copy link
Copy Markdown
Owner

dennis-tra commented Jan 6, 2022

Hey @coryschwartz,

thanks for the PR! I'll take a look at the Helm Chart 👍

I'd rather call the flag db-sslmode, config.DefaultConfig.DatabaseSSLMode and NEBULA_DATABASE_SSL_MODE as there are a couple more SSL related Postgres flags (sslrootcert, sslcert, ...), see https://www.postgresql.org/docs/current/libpq-ssl.html.

Comment thread cmd/nebula/nebula.go
Cory Schwartz and others added 4 commits January 10, 2022 11:11
Co-authored-by: Dennis Trautwein <dennis.trautwein@posteo.de>
Co-authored-by: Dennis Trautwein <dennis.trautwein@posteo.de>
@dennis-tra
Copy link
Copy Markdown
Owner

Thanks @coryschwartz , do you think it's good to go? I'd be happy to merge it now :)

@coryschwartz
Copy link
Copy Markdown
Contributor Author

I think so, thanks!

@dennis-tra dennis-tra merged commit 1bd2bb2 into dennis-tra:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants