Add ghcr.io/gorelease-cross docker to cross-compile binaries#66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The compilation of Nebula requires some CGO dependencies, which heavily complicate the cross-compilation efforts. This PR aims to solve #60 using the Docker images provided by goreleaser/goreleaser-cross
NOTE: Super important to rely on the
ghcr.io/gorelease-crossimages, as there are some C libs missing at the DockerHub images. :(Proof of Success
The compilation works fine locally (with the listed GOOS and GOARCH) when running:
which reports:
Just hoping that there is nothing broken at the GitHub Actions integration (fingerscrossed)
Sorry for the spam @dennis-tra , Let me know if there is anything easier/less spammer to try out the github-actions integrations :(