Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

va-radio-option: add additional override styles to the label#1987

Merged
jamigibbs merged 3 commits intomainfrom
5350-char-encoding-radio
Feb 13, 2026
Merged

va-radio-option: add additional override styles to the label#1987
jamigibbs merged 3 commits intomainfrom
5350-char-encoding-radio

Conversation

@jamigibbs
Copy link
Copy Markdown
Contributor

@jamigibbs jamigibbs commented Feb 12, 2026

Chromatic

https://5350-char-encoding-radio--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

The va-radio-option component is the only component with the shadow dom open. That means that it's susceptible to outside/global style interference.

The component already has a number of style overrides related to Formation to account for this but there are a few more we need to add (see screenshots below). This PR will add those additional override styles.

Related tickets and links

related department-of-veterans-affairs/vets-design-system-documentation#5350

Screenshots

This is an example of the issue that was provided to us:

Screenshot 2026-02-12 at 9 00 46 AM

This is the style that is getting applied to the component because the shadow dom is open. It's originating in the CSS-Library here.

Screenshot 2026-02-11 at 2 01 00 PM

Testing and review

Approvals

See the QA Checklists section below for suggested approvals. Use your best judgment if additional reviews are needed. When in doubt, request a review.

Approval groups

Add approval groups to the PR as needed:

QA checklists

Use the QA checklists below as guides, not rules. Not all checklists will apply to every PR but there could be some overlap.

In all scenarios, changes should be fully tested by the author and verified by the reviewer(s); functionality, responsiveness, etc.

✨ New Component Added
  • The PR has the minor label
  • The component matches the Figma designs.
  • All properties, custom events, and utility functions have e2e and/or unit tests
  • A new Storybook page has been added for the component
  • Tested in all VA breakpoints.
  • Chromatic UI Tests have run and snapshot changes have been accepted by the design reviewer
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
  • Design has approved the PR
  • Accessibility has approved the PR
🌱 New Component Variation Added
  • The PR has the minor label
  • The variation matches its Figma design.
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • A new story has been added to the component's existing Storybook page
  • Any Chromatic UI snapshot changes have been accepted by a design reviewer
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
  • Design has approved the PR
🐞 Component Fix
  • The PR has the patch label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any markup changes are evaluated for impact on vets-website.
    • Will any vets-website tests fail from the change?
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
♿️ Component Fix - Accessibility
  • The PR has the patch label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
  • Accessibility has approved the PR
🚨 Component Fix - Breaking API Change
  • The PR has the major label
  • vets-website and content-build have been evaluated to determine the impact of the breaking change
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
🔧 Component Update - Non-Breaking API Change
  • The PR has the minor label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
📖 Storybook Update
  • The PR has the ignore-for-release label
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
🎨 CSS-Library Update
  • The PR has the css-library label
  • vets-website and content-build have been checked to determine the impact of any breaking changes
  • Engineering has approved the PR

@jamigibbs jamigibbs added the patch Patch change in semantic versioning label Feb 12, 2026
@jamigibbs jamigibbs marked this pull request as ready for review February 12, 2026 16:22
@jamigibbs jamigibbs requested a review from a team as a code owner February 12, 2026 16:22
Copy link
Copy Markdown
Contributor

@ediiotero ediiotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jamigibbs jamigibbs merged commit fb9bd97 into main Feb 13, 2026
7 checks passed
@jamigibbs jamigibbs deleted the 5350-char-encoding-radio branch February 13, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch change in semantic versioning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants