Skip to content

va-file-input: Add password submit button (#1952) - cherry pick from previous revert#1997

Merged
RyanMunsch merged 9 commits intomainfrom
file-input-pw-button-pick
Feb 24, 2026
Merged

va-file-input: Add password submit button (#1952) - cherry pick from previous revert#1997
RyanMunsch merged 9 commits intomainfrom
file-input-pw-button-pick

Conversation

@jamigibbs
Copy link
Copy Markdown
Contributor

@jamigibbs jamigibbs commented Feb 16, 2026 •
edited
Loading

Chromatic

https://file-input-pw-button-pick--65a6e2ed2314f7b8f98609d8.chromatic.com

Summary

Provide a one or two sentence summary of the update that can be used in the changelog.

Component Summary API change Rendered markup change
va-file-input Added password submit button. This update replaces existing file password functionality with an input field for entering the password and a submit button for submitting the password. By @RyanMunsch #1952 Yes Yes

Description

This PR will bring back into main adding the password submit button to va-file-input:

Related tickets and links

Original issue department-of-veterans-affairs/vets-design-system-documentation#4915

Screenshots

Testing and review

Approvals

See the QA Checklists section below for suggested approvals. Use your best judgment if additional reviews are needed. When in doubt, request a review.

Approval groups

Add approval groups to the PR as needed:

QA checklists

Use the QA checklists below as guides, not rules. Not all checklists will apply to every PR but there could be some overlap.

In all scenarios, changes should be fully tested by the author and verified by the reviewer(s); functionality, responsiveness, etc.

✨ New Component Added
  • The PR has the minor label
  • The component matches the Figma designs.
  • All properties, custom events, and utility functions have e2e and/or unit tests
  • A new Storybook page has been added for the component
  • Tested in all VA breakpoints.
  • Chromatic UI Tests have run and snapshot changes have been accepted by the design reviewer
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
  • Design has approved the PR
  • Accessibility has approved the PR
🌱 New Component Variation Added
  • The PR has the minor label
  • The variation matches its Figma design.
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • A new story has been added to the component's existing Storybook page
  • Any Chromatic UI snapshot changes have been accepted by a design reviewer
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
  • Design has approved the PR
🐞 Component Fix
  • The PR has the patch label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any markup changes are evaluated for impact on vets-website.
    • Will any vets-website tests fail from the change?
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
♿️ Component Fix - Accessibility
  • The PR has the patch label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
  • Accessibility has approved the PR
🚨 Component Fix - Breaking API Change
  • The PR has the major label
  • vets-website and content-build have been evaluated to determine the impact of the breaking change
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
🔧 Component Update - Non-Breaking API Change
  • The PR has the minor label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
📖 Storybook Update
  • The PR has the ignore-for-release label
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
🎨 CSS-Library Update
  • The PR has the css-library label
  • vets-website and content-build have been checked to determine the impact of any breaking changes
  • Engineering has approved the PR

@RyanMunsch @amyleadem @jamigibbs
va-file-input: Add password submit button (#1952)
746520b 
* Recreate changes from OG branch (with focus mgmt)

* Temporarily flip `chromatic.onlyChanged` flag

* Revert "Temporarily flip `chromatic.onlyChanged` flag"

This reverts commit 4f229e0.

* Remove commented out story setup

* Clear password on file change and file removal

* Move focus to password input when its in error on password submit

* Add test story with realistic encrypted file flow

* Ensure there's an old file before clearing password state on file change

* Update alert text to match Figma

* Fix expected va-alert innerHTML in test

* Update alert text, message-aria-describedby, button label

---------

Co-authored-by: amyleadem <amyleadem@gmail.com>
@jamigibbs jamigibbs added major Major change in semantic versioning run chromatic workflow Allows a PR to run the chromatic workflow to deploy Chromatic without "ready for review" status. labels Feb 16, 2026
@jamigibbs jamigibbs changed the title va-file-input: Add password submit button (#1952) va-file-input: Add password submit button (#1952) - cherry pick from previous revert Feb 16, 2026
@jamigibbs jamigibbs requested a review from RyanMunsch February 17, 2026 19:14
@jamigibbs jamigibbs removed the run chromatic workflow Allows a PR to run the chromatic workflow to deploy Chromatic without "ready for review" status. label Feb 17, 2026
@jamigibbs jamigibbs marked this pull request as ready for review February 17, 2026 19:25
@jamigibbs jamigibbs requested a review from a team as a code owner February 17, 2026 19:25
RyanMunsch
RyanMunsch approved these changes Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@RyanMunsch RyanMunsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanMunsch RyanMunsch requested a review from a team February 24, 2026 16:55
@RyanMunsch
Copy link
Copy Markdown
Contributor

RyanMunsch commented Feb 24, 2026

There's been a minor change due to a bug flagged by Ian while testing against the forms library. There have also been changes from merging newer PRs in from main. It'd be good to get another round of reviews in, mainly just checking that functionality still looks good in stories for file input and file input multiple.

ediiotero
ediiotero approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ediiotero ediiotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jamigibbs
jamigibbs commented Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I can't approve this PR because I technically created it but I put my approval here! ✅

@RyanMunsch RyanMunsch merged commit c06d1f4 into main Feb 24, 2026
7 of 10 checks passed
@RyanMunsch RyanMunsch deleted the file-input-pw-button-pick branch February 24, 2026 18:56
@RyanMunsch RyanMunsch mentioned this pull request Feb 24, 2026
Merged
44 tasks
@RyanMunsch RyanMunsch mentioned this pull request Mar 11, 2026
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ediiotero ediiotero ediiotero approved these changes

@RyanMunsch RyanMunsch RyanMunsch approved these changes

Assignees

No one assigned

Labels

major Major change in semantic versioning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamigibbs @RyanMunsch @ediiotero