[FSR] Veteran's answers do not match downloadable form

[mgleo]

Issue Description

Veterans report on Medallia that they select "Not married" on the form. When they download their completed form on the confirmation page, it stated "Married".

Tested on staging and this is still happening. Selected a copay and went through the Streamlined waiver as a unmarried Veteran without assets/cash. See screenshots.

---

Veterans report on Medallia that they select "No" when asked if they've ever declared bankruptcy. When they download their completed form, it stated "Yes" under bankruptcy.

Tested on staging and this is still happening.

Outstanding Questions

• Investigate FSR bug
• Fix FSR bug

Tasks

• FSR bug is fixed

Design and engineering sync on implementation of design

• Required
• Complete
• Not Required

Front End & Back End sync on architecture design and implementation

• Required
• Complete
• Not Required

Acceptance Criteria

• Items from the issue description perform as described in the description above
• Feature Flag: does this require a flag to be enabled OR disabled?
• Testing passed and documented in this ticket
• Link PR in ticket (if applicable),"financial-management-team" label is added

Test procedures:
If additional testing steps or credentials to perform testing are needed list them here

[josephrlee]

Just did some initial work on this and tried to see if this was a FE or BE issue, and it looks to be a BE issue related to the PDF PDF generator. I asked copilot to come up with a fix for it in vets-website and it failed.

cc: @digitaldrk

Here's a bit of the output from claude that might be helpful:

❯ Okay, so now I see, when I answer NO for either bankdrupcy or being married, the PDF alwasy fills out Yes. /Users/user/Downloads/VA\ Form\ 5655\ -\ Submitted\ \(2\).pdf                                    
                                                                                                                                                                                                                   
  Read 1 file (ctrl+o to expand)                                                                                                                                                                                   
                                                                                                                                                                                                                   
⏺ Both fields now always show YES/MARRIED regardless of the answer. This suggests the issue isn't about inversion — it might be about what value the form actually stores in questions.isMarried and               
  questions.hasBeenAdjudicatedBankrupt. Let me check the actual form data structure.
                                                                                                                                                                                                                   
  Read 2 files (ctrl+o to expand)                                                                                                                                                                                  
                                                                                                                                                                                                                   
⏺ Let me check the git history to see what the original transform looked like before any of these changes:                                                                                                         
                                                                                                                                                                                                                   
⏺ Bash(git log --oneline src/applications/financial-management/financial-status-report/utils/transform.js | head -10)                                                                                            
  ⎿  b2f33899fe Add explanatory comments for boolean inversion in FSR transform                                                                                                                                    
     944f9ba66b Fix FSR PDF boolean inversion bug for marital status and bankruptcy                                                                                                                                
     419a36b2de 134008 - Move FSR to financial-management Folder in Vets-Website (#43022)                                                                                                                          
                                                                                                                                                                                                                   
⏺ Bash(git show 419a36b2de:src/applications/financial-management/financial-status-report/utils/transform.js | grep -A3 -B3 "married\|bankrupt" | head -40)                                                         
  ⎿          },                                                                                                                                                                                                    
             telephoneNumber: getFormattedPhone(mobilePhone),
             dateOfBirth: formattedBirthDate,                                                                                                                                                                      
     … +18 lines (ctrl+o to expand)                                                                                                                                                                              
                                                                                                                                                                                                                   
⏺ The original code already had no inversion — so we're back to square one. The bug exists in the original code too, meaning false always renders as MARRIED/YES on the PDF. Let me dig into how the backend       
  actually expects these values:                                                          
                                                                                                                                                                                                                   
⏺ Explore(Find FSR backend PDF field mapping)                                                                                                                                                                      
  ⎿  Done (27 tool uses · 53.2k tokens · 50s)                                                                                            
  (ctrl+o to expand)                                                                                                                                                                                               
                                                                                                                                                                                                                   
⏺ The frontend is sending the correct false boolean — the bug is in how the backend PDF generator handles it. Let me look at what the backend actually expects:
                                                                                                                                                                                                                   
  Searched for 2 patterns (ctrl+o to expand)                                                                                                                                                                       
                                                                                                                                                                                                                   
⏺ The frontend is sending false correctly. This is a backend issue. Let me look at the mock server to understand what the backend actually expects:                                                                
                                                                                                                                                                                                                   
⏺ Bash(find /Users/josephlee/Sites/vets-website/src -path "*/mocks*" -name "*.js" | xargs grep -l "financial-status\|fsr\|5655" 2>/dev/null | head -10)                                                            
  ⎿  /Users/user/Sites/vets-website/src/platform/mhv/api/mocks/user/index.js                                                                                                                                  
     /Users/user/Sites/vets-website/src/applications/personalization/common/mocks/users/index.js                                                                                                              
     /Users/user/Sites/vets-website/src/applications/mhv-medical-records/mocks/api/user/index.js                                                                                                              
     … +2 lines (ctrl+o to expand)                                                                                                                                                                                 
                                                                                                                                                                                                                   
  Searching for 3 patterns, reading 1 file… (ctrl+o to expand)                                                                                                                                                     
  ⎿  src/applications/financial-management/financial-status-report/mocks/responses.js                                                                                                                              
                                                                                                                                                                                                                   
  /btw can you show me where the backend genearotor for this PDF is?                                                                                                                                               
                                                                                                                                                                                                                   
    Based on what's visible in this repo, the frontend only sends JSON to the vets-api backend — the actual PDF generator lives in the vets-api Ruby repo, not vets-website.                                       
                                                                                                                                                                                                                   
    The relevant backend location would be:                                                                                                                                                                        
                                                                                                                                                                                                                   
    vets-api/app/workers/debts/fsr_pdf_service.rb                                                                                                                                                                  
    # or similar path under:                                                                                                                                                                                       
    vets-api/modules/debts_api/
                                                                                                                                                                                                                   
    The frontend submits to an endpoint like POST /v0/financial_status_reports and vets-api handles filling the PDF form fields from the JSON payload.                                                             
                                                                                                                                                                                                                   
    To find the exact file, you'd need to search the https://github.com/department-of-veterans-affairs/vets-api for financial_status_report or 5655 — that's where the field mapping between the JSON keys         
    (married, hasBeenAdjudicatedBankrupt) and the actual PDF form fields is defined.
                                          

[josephrlee]

@digitaldrk I have a fix in place and have tested it by filling out both questions as Yes and No and it works after I download the generated PDF I see the right responses.

[josephrlee]

This was pulled in late in the sprint as it was a bug. Might not get merged before Sprint 6 ends.

cc: @HeatherRienks @RakshindaAslam

[josephrlee]

This is going to roll into Sprint 7, as I need BE review/support on this ticket.

cc: @HeatherRienks @RakshindaAslam