Skip to content

Add runtime fallback for Tools Time->duration() method #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
Mar 17, 2026
Merged

Add runtime fallback for Tools Time->duration() method #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion templates/Admin/QueuedJobs/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,12 @@
</span>
<div class="small text-muted">
<i class="fas fa-stopwatch me-1"></i>
<?= $this->Time->duration($queuedJob->completed->diff($queuedJob->fetched)) ?>
<?php
$interval = $queuedJob->completed->diff($queuedJob->fetched);
echo method_exists($this->Time, 'duration')
? $this->Time->duration($interval)
: ltrim($interval->format('%H:%I:%S'), '0:');
?>
</div>
<?php else: ?>
<span class="text-muted">---</span>
Expand Down
16 changes: 14 additions & 2 deletions templates/Admin/QueuedJobs/view.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,13 @@
<?php if ($queuedJob->fetched): ?>
<?= $this->Time->nice($queuedJob->fetched) ?>
<div class="small text-muted">
<?= __d('queue', 'Delay') ?>: <?= $this->Time->duration($queuedJob->fetched->diff($queuedJob->created)) ?>
<?php
$interval = $queuedJob->fetched->diff($queuedJob->created);
$duration = method_exists($this->Time, 'duration')
? $this->Time->duration($interval)
: ltrim($interval->format('%H:%I:%S'), '0:');
?>
<?= __d('queue', 'Delay') ?>: <?= $duration ?>
</div>
<?php else: ?>
<span class="text-muted">---</span>
Expand All @@ -159,7 +165,13 @@
<?= $this->Time->nice($queuedJob->completed) ?>
</span>
<div class="small text-muted">
<?= __d('queue', 'Duration') ?>: <?= $this->Time->duration($queuedJob->completed->diff($queuedJob->fetched)) ?>
<?php
$interval = $queuedJob->completed->diff($queuedJob->fetched);
$duration = method_exists($this->Time, 'duration')
? $this->Time->duration($interval)
: ltrim($interval->format('%H:%I:%S'), '0:');
?>
<?= __d('queue', 'Duration') ?>: <?= $duration ?>
</div>
<?php else: ?>
<span class="text-muted">---</span>
Expand Down
Loading