Skip to content

Fix master CI: eviction-guard test premise after dropping unique index #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
May 8, 2026
Merged

Fix master CI: eviction-guard test premise after dropping unique index #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions tests/TestCase/Model/Table/QueueProcessesTableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
namespace Queue\Test\TestCase\Model\Table;

use Cake\Core\Configure;
use Cake\Database\Exception\QueryException;
use Cake\I18n\DateTime;
use Cake\ORM\Exception\PersistenceFailedException;
use Cake\ORM\TableRegistry;
Expand Down Expand Up @@ -311,20 +310,23 @@ public function testAddEvictsStaleRowOnSamePidServer() {

/**
* If the existing row is fresh (recent heartbeat), it represents a real,
* live worker — eviction would be wrong. The duplicate-key error is the
* correct outcome. `Queue.maxworkers` is raised so `validateCount` cannot
* mask the real source of failure: the (pid, server) unique index fires
* at the DB level as a `QueryException`, not validation.
* live worker — the eviction guard inside `add()` must NOT touch it.
* Verifies the threshold check (`modified <` clause) by asserting the
* pre-existing row survives a second `add()` on the same (pid, server).
*
* @return void
*/
public function testAddDoesNotEvictRecentRowOnSamePidServer() {
Configure::write('Queue.maxworkers', 5);
$this->QueueProcesses->deleteAll(['1=1']);
$this->QueueProcesses->add('8', 'first-workerkey');
$firstId = $this->QueueProcesses->add('8', 'first-workerkey');

$this->expectException(QueryException::class);
$this->QueueProcesses->add('8', 'second-workerkey');

$this->assertTrue(
$this->QueueProcesses->exists(['id' => $firstId]),
'Recent row should not be evicted by a subsequent add() on the same (pid, server).',
);
}

/**
Expand Down
Loading