Skip to content

Change variable names in the gaussian fittings#219

Merged
astropenguin merged 7 commits into
mainfrom
issue218
Feb 13, 2025
Merged

Change variable names in the gaussian fittings#219
astropenguin merged 7 commits into
mainfrom
issue218

Conversation

@ShinjiFujita
Copy link
Copy Markdown
Contributor

Changed variable names in the gaussian fitting results.
Params are stored in dict (fit_res_params_dict).

@astropenguin astropenguin changed the title Update qlook.py (issue218) Change variable names in the gaussian fittings Dec 6, 2024
@astropenguin astropenguin added the feature New feature or request label Dec 6, 2024
@astropenguin astropenguin added this to the v2024.12 milestone Dec 6, 2024
Copy link
Copy Markdown
Member

@astropenguin astropenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the long silence to check your updates. It looks no problem, but let me update the following points in terms of the package being used as a command line tool:

  1. Let us use Python's logging for the notification on a 2D Gaussian fit failure. As a command line tool (decode-qlook), outputting such information to stdout is sometimes not wanted, for example, when another tool is connected to by a pipe to use the return value of decode-qlook (i.e. path of the final product). Using Python's logging allows users to fully control the notification style, so I think it would merit more.
  2. Let me add missing return type hints and docstrings of the function you added. If you feel that they are not appropriate, please feel free to let me know or raise another issue/PR.

@astropenguin astropenguin merged commit 7ee8470 into main Feb 13, 2025
@astropenguin astropenguin deleted the issue218 branch February 13, 2025 05:57
@astropenguin
Copy link
Copy Markdown
Member

This closed #218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants