Change variable names in the gaussian fittings#219
Merged
Conversation
astropenguin
approved these changes
Feb 13, 2025
Member
There was a problem hiding this comment.
My apologies for the long silence to check your updates. It looks no problem, but let me update the following points in terms of the package being used as a command line tool:
- Let us use Python's logging for the notification on a 2D Gaussian fit failure. As a command line tool (decode-qlook), outputting such information to stdout is sometimes not wanted, for example, when another tool is connected to by a pipe to use the return value of decode-qlook (i.e. path of the final product). Using Python's logging allows users to fully control the notification style, so I think it would merit more.
- Let me add missing return type hints and docstrings of the function you added. If you feel that they are not appropriate, please feel free to let me know or raise another issue/PR.
Member
|
This closed #218. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed variable names in the gaussian fitting results.
Params are stored in dict (fit_res_params_dict).