Skip to content

Fs table columns#4

Merged
ric-v merged 2 commits into
dev-asterix:mainfrom
ric-v:fs-table-columns
Apr 7, 2025
Merged

Fs table columns#4
ric-v merged 2 commits into
dev-asterix:mainfrom
ric-v:fs-table-columns

Conversation

@ric-v
Copy link
Copy Markdown
Member

@ric-v ric-v commented Apr 7, 2025

This pull request introduces several enhancements and new features to the postgres-explorer extension, including version updates, new commands, and improved logging. The most important changes are summarized below.

Enhancements and New Features:

  • package.json: Updated the extension version to 0.0.5, added a new command postgres-explorer.showViewProperties, and included new build scripts using esbuild for bundling and minification. Additionally, added esbuild and webpack dependencies. [1] [2] [3] [4]

  • src/extension.ts: Introduced new logging statements for better debugging and added a new command postgres-explorer.showViewProperties to display properties of a database view. Improved the message handling in the PostgresKernel for export commands. [1] [2]

Codebase Improvements:

  • src/notebookKernel.ts: Enhanced the PostgresKernel class by adding a message handler and logging statements to track the execution flow and debug issues more effectively. [1] [2]

These changes collectively improve the functionality, maintainability, and debuggability of the postgres-explorer extension.

ric-v added 2 commits April 7, 2025 22:34
- Introduced a new command "postgres-explorer.showViewProperties" to display properties of database views.
- Updated the command registration in extension.ts to handle view selection and connection validation.
- Enhanced the TablePropertiesPanel to differentiate between tables and views, fetching the appropriate definitions.
- Improved the notebook output UI with export options for CSV, Excel, and JSON formats, including a clear output button.
- Refactored HTML and CSS for better layout and usability in the notebook output.
@ric-v ric-v requested a review from Copilot April 7, 2025 18:44
@ric-v ric-v self-assigned this Apr 7, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

src/tableProperties.ts:5

  • [nitpick] The parameter 'name' is ambiguous since it represents either a table or a view. Consider renaming it to 'objectName' for clarity.
public static async show(client: Client, schema: string, name: string, isView: boolean = false): Promise<void> {

src/notebookKernel.ts:312

  • Consider adding a null-check to ensure that the element with id 'exportMenu' exists before attempting to modify its classList.
document.getElementById('exportMenu').classList.remove('show');

@ric-v ric-v merged commit 0b27b99 into dev-asterix:main Apr 7, 2025
ric-v added a commit that referenced this pull request Dec 4, 2025
[WIP] Integrate with AI provider for actual responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants