Change static file references to inputs#27
Merged
chris-rock merged 1 commit intodev-sec:masterfrom Apr 16, 2020
thheinen:theinen/more-attributes
Merged
Change static file references to inputs#27chris-rock merged 1 commit intodev-sec:masterfrom thheinen:theinen/more-attributes
chris-rock merged 1 commit intodev-sec:masterfrom
thheinen:theinen/more-attributes
Conversation
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
chris-rock
approved these changes
Apr 16, 2020
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Great addition @tecracer-theinen 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assessing a cluster which was set up using KOPS, I noticed that all configuration files had hardcoded values which did not fit this environemtn. In addition, the name of the
etcdprocess was hardcoded as well.With this PR, I propose to change those into inputs, which have the same default value as in the code before.
I also switched from
default:tovalue:for the inputs to get rid of deprecation warnings.